Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11021 )
Change subject: IMPALA-6214: Determine and warn about stuck fragment instances. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11021/2/be/src/runtime/krpc-data-stream-recvr.cc File be/src/runtime/krpc-data-stream-recvr.cc: http://gerrit.cloudera.org:8080/#/c/11021/2/be/src/runtime/krpc-data-stream-recvr.cc@238 PS2, Line 238: VLOG_QUERY << "wait arrival fragment_instance_id=" > VLOG_QUERY is on by default, so this would become very very noisy, once per I don't think this is the right place for this check. We should instead perform this in or around the loop in FragmentInstanceState::ExecInternal(). We need to come up with a way to expose this on a per-query basis, either on a status page or (preferably) in the profile, so that other tools can parse this more easily. In addition, we should think about how we can prevent false posiitives, i.e. only report an instance that blocks, but is not blocked by any of its inputs. -- To view, visit http://gerrit.cloudera.org:8080/11021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I260a1d0a3477e5c6a46094e664500c3e2ed7de62 Gerrit-Change-Number: 11021 Gerrit-PatchSet: 2 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 31 Jul 2018 17:46:36 +0000 Gerrit-HasComments: Yes
