Quanlong Huang has posted comments on this change. (
http://gerrit.cloudera.org:8080/11092 )
Change subject: Add RapidJson 1.1.0
......................................................................
Patch Set 1:
There're some broken APIs to fix. For example
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.cc: In
member function ‘kudu::Status kudu::JsonReader::Init()’:
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.cc:40:80:
error: no matching function for call to ‘kudu::Status::Corruption(const char
[21], rapidjson::ParseErrorCode)’
return Status::Corruption("JSON text is corrupt",
document_.GetParseError());
^
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.cc:40:80:
note: candidate is:
In file included from
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.h:27:0,
from
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/jsonreader.cc:18:
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/status.h:228:17:
note: static kudu::Status kudu::Status::Corruption(const kudu::Slice&, const
kudu::Slice&, int16_t)
static Status Corruption(const Slice& msg, const Slice& msg2 = Slice(),
^
/mnt/volume1/impala-orc/incubator-impala/be/src/kudu/util/status.h:228:17:
note: no known conversion for argument 2 from ‘rapidjson::ParseErrorCode’ to
‘const kudu::Slice&’
make[3]: *** [be/src/kudu/util/CMakeFiles/kudu_util.dir/jsonreader.cc.o] Error 1
make[2]: *** [be/src/kudu/util/CMakeFiles/kudu_util.dir/all] Error 2
make[1]: *** [be/src/service/CMakeFiles/impalad.dir/rule] Error 2
make: *** [impalad] Error 2
I think I can help on this if they're not too much.
--
To view, visit http://gerrit.cloudera.org:8080/11092
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie98462fde43c97101e95d0761be1594bc2636859
Gerrit-Change-Number: 11092
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 01 Aug 2018 01:14:57 +0000
Gerrit-HasComments: No
