Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 )
Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER ...................................................................... Patch Set 1: > Patch Set 1: > > For cleaning up the toolchain, we've historically "simply" made sure that > every toolchain artifact has a unique name. i.e., if we push > $CDH_BUILD_NUMBER into the cdh_components directory name, the problem goes > away a bit more gracefully. > > For Maven, I don't have a great idea except pushing $CDH_BUILD_NUMBER into > the maven repository name, which may or may not work. Does it slow down > builds to add the -U? I agree, that's one solution although we may end up with more unused files. I still find it better for clean.sh tries to clean everything, which includes the toolchain directory whether or not we push $CDH_BUILD_NUMBER into cdh_components directory name. For Maven, yes -U does slow down a bit. For development, people can choose to use the existing -noclean flag to skip all those things. The nice thing is there's no additional flag for buildall.sh, which means Jenkins jobs don't need to be updated and people don't need to learn a new flag. Let me know what you think. -- To view, visit http://gerrit.cloudera.org:8080/11099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be Gerrit-Change-Number: 11099 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Wed, 01 Aug 2018 16:09:00 +0000 Gerrit-HasComments: No
