Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 )
Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility and expose JMX metrics ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/10998/9/fe/src/test/java/org/apache/impala/util/JMXJsonUtilTest.java File fe/src/test/java/org/apache/impala/util/JMXJsonUtilTest.java: http://gerrit.cloudera.org:8080/#/c/10998/9/fe/src/test/java/org/apache/impala/util/JMXJsonUtilTest.java@20 PS9, Line 20: import static org.junit.Assert.*; > I think our style guide avoids wildcard imports. You're only using assertTr Done http://gerrit.cloudera.org:8080/#/c/10998/9/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/10998/9/tests/webserver/test_web_pages.py@75 PS9, Line 75: assert "text/plain" in response.headers['Content-Type'] > I think this should be application/json. (https://stackoverflow.com/questio It turns out that ?raw is not the right thing to use in this case and ?json is intended for this purpose. I fixed setting the mime type in a separate patch[1]. Will rebase this on top of it once it is committed. I had to make a few other changes to get this one working as expected. [1] https://gerrit.cloudera.org/#/c/11110/ -- To view, visit http://gerrit.cloudera.org:8080/10998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d897b7e063846ad6d8f88243e2c04264da0341 Gerrit-Change-Number: 10998 Gerrit-PatchSet: 9 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 06:31:43 +0000 Gerrit-HasComments: Yes
