Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11110 )
Change subject: IMPALA-7387: Set correct MIME type for JSON webpages ...................................................................... Patch Set 7: Code-Review+2 (2 comments) Carrying +2 http://gerrit.cloudera.org:8080/#/c/11110/4/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/11110/4/be/src/util/webserver.cc@438 PS4, Line 438: bool raw_json = (arguments.find("json") != arguments.end()); > Could you update webserver.h's comment for this function with what ?json an Elaborated it a bit more. http://gerrit.cloudera.org:8080/#/c/11110/4/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/11110/4/tests/webserver/test_web_pages.py@97 PS4, Line 97: assert content_type == requests.get(url).headers['Content-Type'] > Should this be "==" rather than "in"? Done -- To view, visit http://gerrit.cloudera.org:8080/11110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 11110 Gerrit-PatchSet: 7 Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 22:14:32 +0000 Gerrit-HasComments: Yes
