Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 )
Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh@473 PS2, Line 473: if [[ -f ${CDH_FILE} ]]; then : if [[ $(cat ${CDH_FILE}) != ${CDH_BUILD_NUMBER} ]]; then : export IMPALA_MAVEN_OPTIONS="${IMPALA_MAVEN_OPTIONS} -U" : fi : fi : echo "${CDH_BUILD_NUMBER}" > ${CDH_FILE} : : if [[ "$BUILD_FE_ONLY" -eq 1 ]]; then : build_fe : exit 0 : fi > I'm thinking about this a bit. It's a bit of a weird case. Agreed, it's a bit of a weird case. Not a big fan of this approach either but I can't think of a better way of detect CDH_BUILD_IMPALA changes. -- To view, visit http://gerrit.cloudera.org:8080/11099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be Gerrit-Change-Number: 11099 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 22:37:39 +0000 Gerrit-HasComments: Yes
