Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11079 )
Change subject: IMPALA-7258: Support querying HBase tables in LocalCatalog ...................................................................... Patch Set 2: (15 comments) mostly minor comments, otherwise, looks fine. http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG@9 PS2, Line 9: porting nit: port http://gerrit.cloudera.org:8080/#/c/11079/2//COMMIT_MSG@10 PS2, Line 10: passes nit: pass http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@26 PS2, Line 26: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableDropColStmt.java@23 PS2, Line 23: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetStmt.java@23 PS2, Line 23: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@33 PS2, Line 33: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/AlterTableSortByStmt.java@26 PS2, Line 26: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@50 PS2, Line 50: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@35 PS2, Line 35: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java File fe/src/main/java/org/apache/impala/catalog/HBaseTable.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/HBaseTable.java@50 PS2, Line 50: Input format class for HBase tables read by Hive. move this comment before L51, then bring the "implements" up a line. http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java File fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java@55 PS2, Line 55: import org.apache.tools.ant.taskdefs.Local; remove (ide expansion?) http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java File fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/HBaseScanNode.java@40 PS2, Line 40: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/Planner.java File fe/src/main/java/org/apache/impala/planner/Planner.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/Planner.java@38 PS2, Line 38: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@62 PS2, Line 62: import org.apache.impala.catalog.HBaseTable; remove http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11079/2/fe/src/main/java/org/apache/impala/service/Frontend.java@88 PS2, Line 88: import org.apache.impala.catalog.HBaseTable; remove -- To view, visit http://gerrit.cloudera.org:8080/11079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8cc94bc38861443de5a375b7e63d29215e0ca899 Gerrit-Change-Number: 11079 Gerrit-PatchSet: 2 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 02 Aug 2018 23:19:43 +0000 Gerrit-HasComments: Yes
