Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10813 )
Change subject: IMPALA-7163: Implement a state machine for the QueryState class ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/10813/12/be/src/runtime/fragment-instance-state.cc File be/src/runtime/fragment-instance-state.cc: http://gerrit.cloudera.org:8080/#/c/10813/12/be/src/runtime/fragment-instance-state.cc@106 PS12, Line 106: if (!status.ok() && current_state_.Load() <= TFInstanceExecState::WAITING_FOR_PREPARE) { : // Tell the managing 'QueryState' that we hit an error during Prepare(). : query_state_->ErrorDuringPrepare(status, instance_id()); : } else if (!status.ok()) { : // Tell the managing 'QueryState' that we hit an error during execution. : query_state_->ErrorDuringExecute(status, instance_id()); : } > Seems easier to read if written like the following: Done http://gerrit.cloudera.org:8080/#/c/10813/12/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/10813/12/be/src/runtime/query-state.h@244 PS12, Line 244: Status WaitForFinish(); > Is this actually still needed in this patch ? It doesn't seem to be called We call it towards the end of StartFInstances(). We update the query state only after this unblocks. http://gerrit.cloudera.org:8080/#/c/10813/12/tests/failure/test_failpoints.py File tests/failure/test_failpoints.py: http://gerrit.cloudera.org:8080/#/c/10813/12/tests/failure/test_failpoints.py@162 PS12, Line 162: i = 0 > This line isn't needed if you use for i in range(50) below. When I remove this, it gives me this error: "NameError: global name 'i' is not defined" -- To view, visit http://gerrit.cloudera.org:8080/10813 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec5670a7db83ecae4656d7bb2ea372d3767ba7fe Gerrit-Change-Number: 10813 Gerrit-PatchSet: 12 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Comment-Date: Fri, 03 Aug 2018 12:19:39 +0000 Gerrit-HasComments: Yes
