Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/11106 )
Change subject: IMPALA-7385: Fix test-with-docker errors having to do with time zones. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11106/2/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/11106/2/docker/test-with-docker.py@506 PS2, Line 506: # Ubuntu16.04 machines use an absolute symlink here, : # e.g., /etc/localtime -> /usr/share/zoneinfo/America/Los_Angeles : # but CentOS7 uses a relative one, e.g., /etc/localtime -> ../usr/share/zoneinfo/UTC, : # so we use "in" rather than "startswith" Thaks for the explanation. I tested os.path.realpath() quickly in a REPL and it always returns an absolute canonical path, even if the symlink contained a relative path. Python docs: "os.path.realpath(filename): Return the canonical path of the specified filename, eliminating any symbolic links encountered in the path." so I think, 'startswith' should always work. -- To view, visit http://gerrit.cloudera.org:8080/11106 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia9facfd9741806e7dbb868d8d06d9296bf86e52f Gerrit-Change-Number: 11106 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Comment-Date: Fri, 03 Aug 2018 12:55:57 +0000 Gerrit-HasComments: Yes
