Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11110 )
Change subject: IMPALA-7387: Set correct MIME type for JSON webpages ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/11110/9/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/11110/9/be/src/util/webserver.cc@151 PS9, Line 151: \ > Compatible Chinese should add charset=utf-8 I don't think that is a standard. Relevant discussion here [1] which refers to [2] that says "Note: No "charset" parameter is defined for this registration. Adding one really has no effect on compliant recipients." Also, I tried running a sample query in chinese charset and I can see it fine in my firefox browser without UTF-8 charset in the HTTP header. Here is a screenshot [3] [1] https://github.com/request/request/issues/383 [2] http://www.iana.org/assignments/media-types/application/json [3] https://pasteboard.co/HxvPg1X.png -- To view, visit http://gerrit.cloudera.org:8080/11110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ad94343151730851a4ad01a1f4b9326a36a37ea Gerrit-Change-Number: 11110 Gerrit-PatchSet: 9 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #168 Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Fri, 03 Aug 2018 21:00:35 +0000 Gerrit-HasComments: Yes
