Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10855 )
Change subject: IMPALA-7213: Port ReportExecStatus() RPC to use KRPC ...................................................................... Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/runtime/query-state.h@276 PS5, Line 276: to construct a fragment instance's status report "... to construct a status report ..." Since if 'fis' is nullptr, then we send a generic report with only the status of the query. http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/runtime/query-state.h@277 PS5, Line 277: The runtime profile "If 'fis' is not 'nullptr', the runtime profile ..." http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/runtime/query-state.cc@256 PS5, Line 256: query ID $1 Shouldn't we print the fragment instance ID instead? http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/runtime/query-state.cc@295 PS5, Line 295: The profile is serialized in Thrift The profile is a thrift structure serialized to a string ... http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/runtime/query-state.cc@306 PS5, Line 306: sidecar_buf->assign_copy(profile_str); We could probably consider moving 'profile_str' to the 'sidecar_buf' to avoid the copy, but that requires changes in Kudu code, so we can defer for later. http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/runtime/query-state.cc@304 PS5, Line 304: if (!profile_str.empty()) { : unique_ptr<kudu::faststring> sidecar_buf = make_unique<kudu::faststring>(); : sidecar_buf->assign_copy(profile_str); : unique_ptr<RpcSidecar> sidecar = RpcSidecar::FromFaststring(move(sidecar_buf)); : : int sidecar_idx; : kudu::Status sidecar_status = : rpc_controller.AddOutboundSidecar(move(sidecar), &sidecar_idx); : CHECK(sidecar_status.ok()) : << FromKuduStatus(sidecar_status, "Failed to add sidecar").GetDetail(); : : DCHECK_EQ(report.instance_exec_status_size(), 1); : report.mutable_instance_exec_status(0)->set_thrift_profile_sidecar_idx(sidecar_idx); : } Can't we just do this once before the loop starts? http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/util/error-util.cc File be/src/util/error-util.cc: http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/util/error-util.cc@144 PS5, Line 144: auto auto& http://gerrit.cloudera.org:8080/#/c/10855/5/be/src/util/error-util.cc@172 PS5, Line 172: auto auto& -- To view, visit http://gerrit.cloudera.org:8080/10855 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7638583b433dcac066b87198e448743d90415ebe Gerrit-Change-Number: 10855 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sun, 05 Aug 2018 21:34:47 +0000 Gerrit-HasComments: Yes
