Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11132 )
Change subject: IMPALA-7397: fix DCHECK in impala::AggregationNode::Close ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11132/2/be/src/exec/aggregation-node.cc File be/src/exec/aggregation-node.cc: http://gerrit.cloudera.org:8080/#/c/11132/2/be/src/exec/aggregation-node.cc@41 PS2, Line 41: // The conjuncts will be evaluated in the Aggregator, so don't pass them to the > Maybe leave TODO to remove this? Done -- To view, visit http://gerrit.cloudera.org:8080/11132 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65ae00ac23a62ab9f4a7ff06ac9ad5cece80c39d Gerrit-Change-Number: 11132 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 20:33:24 +0000 Gerrit-HasComments: Yes
