Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11005 )
Change subject: IMPALA-6153: Execute UpdateFilter() only for executing queries ...................................................................... Patch Set 8: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/11005/6/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/11005/6/be/src/runtime/coordinator.cc@265 PS6, Line 265: lock_guard<shared_mutex> lock(filter_lock_); : for (const FragmentExecParams& fragment_params: schedule_.fragment_exec_params()) { : int num_instances = fragment_params.instance_exec_par > Make sense. I have removed the comment. I have kept the lock_guard for the keeping the lock seems ok to me -- To view, visit http://gerrit.cloudera.org:8080/11005 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I669db217f86db5ff2802335e7b1ae8027ea7161c Gerrit-Change-Number: 11005 Gerrit-PatchSet: 8 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 07 Aug 2018 22:13:02 +0000 Gerrit-HasComments: Yes
