Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10974 )
Change subject: IMPALA-7311. Allow INSERT on writable partitions even if some other partition is READ_ONLY ...................................................................... IMPALA-7311. Allow INSERT on writable partitions even if some other partition is READ_ONLY This changes the permissions-checking of INSERT so that, if a partition is specified, we only verify writability of the specific explicit partition. This allows insertion into a table even if it contains one or more read-only partitions. This matches the existing behavior of LOAD DATA. New regression tests are added which failed prior to the fix. Change-Id: I1dd81100ae73fcabdbfaf679c20cea7dc102cd13 Reviewed-on: http://gerrit.cloudera.org:8080/10974 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Tianyi Wang <tw...@cloudera.com> --- M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java M fe/src/main/java/org/apache/impala/analysis/LoadDataStmt.java M fe/src/main/java/org/apache/impala/catalog/FeFsTable.java M fe/src/main/java/org/apache/impala/catalog/HdfsTable.java M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java M tests/metadata/test_hdfs_permissions.py M tests/query_test/test_insert_behaviour.py 8 files changed, 221 insertions(+), 61 deletions(-) Approvals: Impala Public Jenkins: Verified Tianyi Wang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/10974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1dd81100ae73fcabdbfaf679c20cea7dc102cd13 Gerrit-Change-Number: 10974 Gerrit-PatchSet: 10 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
