Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11153 )
Change subject: IMPALA-7388. Fix issues in and optimize various Status macros ...................................................................... Patch Set 1: > Patch Set 1: > > You could also do the const& thing in > be/src/service/impala-beeswax-service.cc and be/src/exec/kudu-util.h > > be/src/service/impala-hs2-service.cc is also fishy in that it doesn't > surround status in parentheses, so might be good to fix while we're fixing > this kind of thing. yep, missed those other cases. Done -- To view, visit http://gerrit.cloudera.org:8080/11153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d62c99bbd83cc290f5992077258af156eaa6330 Gerrit-Change-Number: 11153 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 08 Aug 2018 00:21:16 +0000 Gerrit-HasComments: No
