Hello Todd Lipcon, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11159
to look at the new patch set (#2).
Change subject: Switch a couple of lists to deques in AnalyticEvalNode
......................................................................
Switch a couple of lists to deques in AnalyticEvalNode
I noticed this inefficiency while looking at this code.
std::deque generally offers better performance because it does fewer
memory allocations and has better memory locality. The main advantages
of std::list are O(1) insert/delete in the middle of the list and
stable iterators that remain valid through list modifications,
but neither property is useful for these result_tuples_ and
window_tuples_ because we only append at the back, remove from the front
and iterate over the whole list at once.
Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
---
M be/src/exec/analytic-eval-node.cc
M be/src/exec/analytic-eval-node.h
2 files changed, 13 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/11159/2
--
To view, visit http://gerrit.cloudera.org:8080/11159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaa716dcf241a0a9e4f5221e5cf7a1596c75aecc0
Gerrit-Change-Number: 11159
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
