Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11154 )
Change subject: IMPALA-7400: [DOCS] Updated outdated contents from imapala_proting ...................................................................... Patch Set 1: (3 comments) Thank you alex! Had a couple more comments where I missed things when filing the JIRA. http://gerrit.cloudera.org:8080/#/c/11154/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11154/1//COMMIT_MSG@7 PS1, Line 7: imapala_proting typo: impala_porting http://gerrit.cloudera.org:8080/#/c/11154/1/docs/topics/impala_porting.xml File docs/topics/impala_porting.xml: http://gerrit.cloudera.org:8080/#/c/11154/1/docs/topics/impala_porting.xml@406 PS1, Line 406: <p> Impala supports subqueries only in the <codeph>FROM</codeph> I might have missed this one. This seems very out-of-date. I wonder if it's more maintainable to say something generic like "Impala has some restrictions on subquery support" and point them to https://impala.apache.org/docs/build/html/topics/impala_subqueries.html http://gerrit.cloudera.org:8080/#/c/11154/1/docs/topics/impala_porting.xml@448 PS1, Line 448: <p> Impala does not support certain rarely used join types that are I looked at postgres docs and a couple of other DBMS systems and I think the only limitation is that we don't support NATURAL JOIN and we don't support the USING clause. So we can be more specific here. The bit about "high-volume tables" i think only makes sense for CROSS JOIN so doesn't seem relevant any more. https://www.postgresql.org/docs/current/static/queries-table-expressions.html -- To view, visit http://gerrit.cloudera.org:8080/11154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a1edb1ec5076354df9301ce12e7618d7cf607a6 Gerrit-Change-Number: 11154 Gerrit-PatchSet: 1 Gerrit-Owner: Alex Rodoni <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 08 Aug 2018 19:06:36 +0000 Gerrit-HasComments: Yes
