Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11104 )

Change subject: IMPALA-7383: Configurable HMS and Sentry policy DB
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

This looks good to me. When this goes in, it can break people's existing 
dataload, so we should send out an email to dev@ to notify people and let them 
know that a workaround is to set METASTORE_DB=hive_impala and 
SENTRY_DB=sentry_policy (which can go in bin/impala-config-local.sh or their 
env before sourcing bin/impala-config.sh).

http://gerrit.cloudera.org:8080/#/c/11104/5/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/11104/5/bin/impala-config.sh@323
PS5, Line 323: export METASTORE_DB=\
             : ${METASTORE_DB-$(cut -c-63 <<< HMS$ESCAPED_IMPALA_HOME)}
             : export SENTRY_POLICY_DB=\
             : ${SENTRY_POLICY_DB-$(cut -c-63 <<< SP$ESCAPED_IMPALA_HOME)}
Nit: I think each of these would fit on a single line without the line break.



--
To view, visit http://gerrit.cloudera.org:8080/11104
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I190d657cb95dfdf73ebd05e5dd24ef2a8e3156b8
Gerrit-Change-Number: 11104
Gerrit-PatchSet: 5
Gerrit-Owner: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
Gerrit-Comment-Date: Wed, 08 Aug 2018 21:10:49 +0000
Gerrit-HasComments: Yes

Reply via email to