Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11153 )
Change subject: IMPALA-7388. Fix issues in and optimize various Status macros ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11153/3/be/src/common/status.h File be/src/common/status.h: http://gerrit.cloudera.org:8080/#/c/11153/3/be/src/common/status.h@291 PS3, Line 291: const ::impala::Status& _status = (stmt); \ > While you're here, maybe consider fixing these names. From the standard's [ Done, at least in the areas this patch touches. There are a few others lurking but didn't want to expact scope of this patch to other areas. -- To view, visit http://gerrit.cloudera.org:8080/11153 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d62c99bbd83cc290f5992077258af156eaa6330 Gerrit-Change-Number: 11153 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 08 Aug 2018 23:16:09 +0000 Gerrit-HasComments: Yes
