Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11178 )

Change subject: Make collect_diagnostics executable and minor argument-parsing 
changes.
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/11178/1/bin/diagnostics/collect_diagnostics.py
File bin/diagnostics/collect_diagnostics.py:

http://gerrit.cloudera.org:8080/#/c/11178/1/bin/diagnostics/collect_diagnostics.py@510
PS1, Line 510: t
> flake8: E501 line too long (94 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/11178/1/bin/diagnostics/collect_diagnostics.py@533
PS1, Line 533: *
> flake8: E226 missing whitespace around arithmetic operator
Done


http://gerrit.cloudera.org:8080/#/c/11178/1/bin/diagnostics/collect_diagnostics.py@533
PS1, Line 533: *
> flake8: E226 missing whitespace around arithmetic operator
Done


http://gerrit.cloudera.org:8080/#/c/11178/1/bin/diagnostics/collect_diagnostics.py@533
PS1, Line 533: *
> flake8: E226 missing whitespace around arithmetic operator
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If4d021c2f6f9dec62d6865d32ec0419e41a2441c
Gerrit-Change-Number: 11178
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Comment-Date: Thu, 09 Aug 2018 20:28:40 +0000
Gerrit-HasComments: Yes

Reply via email to