Tim Armstrong has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11180 )
Change subject: IMPALA-7420: Different error messages for internal cancellation ...................................................................... IMPALA-7420: Different error messages for internal cancellation I started by converting scan and spill-to-disk because the cancellation there is always meant to be internal to the scan and spill-to-disk subsystems. This is to aid triage and debugging of bugs like IMPALA-7418 where an "internal" cancellation leaks out into the query state. This will make it easier to determine if an internal cancellation somehow "leaked" out. Ultimately we might want to use different error codes, but there is a significant amount of subtle logic that checks for TErrorCode::CANCELLED. Testing: Ran exhaustive tests. Change-Id: Icfd69adfa4b06a68ebef9c350af66f18e0309b8d --- M be/src/common/status.cc M be/src/common/status.h M be/src/exec/hdfs-orc-scanner.cc M be/src/exec/hdfs-parquet-scanner.cc M be/src/exec/hdfs-scan-node.cc M be/src/exec/hdfs-scanner.cc M be/src/exec/scanner-context.cc M be/src/runtime/io/disk-io-mgr-test.cc M be/src/runtime/io/request-context.cc M be/src/runtime/tmp-file-mgr.cc 10 files changed, 43 insertions(+), 19 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/11180/2 -- To view, visit http://gerrit.cloudera.org:8080/11180 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icfd69adfa4b06a68ebef9c350af66f18e0309b8d Gerrit-Change-Number: 11180 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]>
