Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11194 )
Change subject: IMPALA-7426: Use Mann-Whitney U to compare benchmarks ...................................................................... Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@121 PS1, Line 121: > flake8: E502 the backslash is redundant between brackets Done http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@380 PS1, Line 380: > flake8: E703 statement ends with a semicolon Done http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@396 PS1, Line 396: , > flake8: F821 undefined name 'ref_results' This whole section was, even in HEAD, indented 4 spaces, which puts it at the class level, not the method level. I indented in 6 spaces now, but something was already fishy here. http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@573 PS1, Line 573: a > flake8: W503 line break before binary operator This is now flipped? https://github.com/python/peps/commit/c59c4376ad233a62ca4b3a6060c81368bd21e85b I'll send another patch. http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@1016 PS1, Line 1016: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11194/1/tests/benchmark/report_benchmark_results.py@1036 PS1, Line 1036: > flake8: E501 line too long (94 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/11194/1/tests/util/calculation_util.py File tests/util/calculation_util.py: http://gerrit.cloudera.org:8080/#/c/11194/1/tests/util/calculation_util.py@71 PS1, Line 71: > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/11194/1/tests/util/calculation_util.py@75 PS1, Line 75: > flake8: E231 missing whitespace after ',' Done http://gerrit.cloudera.org:8080/#/c/11194/1/tests/util/calculation_util.py@76 PS1, Line 76: , > flake8: E231 missing whitespace after ',' Done -- To view, visit http://gerrit.cloudera.org:8080/11194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d6631ebeba1422b832def5cd68537624f672fa0 Gerrit-Change-Number: 11194 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Comment-Date: Sun, 12 Aug 2018 22:08:07 +0000 Gerrit-HasComments: Yes
