Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11191 )
Change subject: IMPALA-7408: add a flag to disable reading fs data from catalogd ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/11191/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11191/4//COMMIT_MSG@9 PS4, Line 9: disable_catalog_data_ops > Maybe call it --disable_catalog_data_ops_debug_only or something like that, Its marked hidden, so I'm not worried about that (at least, I don't recall the other example of a hidden flag, krpc, having that concern). But I think in the two places its used in the code, it'll make it clearer that the test is only for debugging. http://gerrit.cloudera.org:8080/#/c/11191/4//COMMIT_MSG@17 PS4, Line 17: > Should we add a banner on the catalogd web UI page if this is set? I think that's overkill, since it hidden. But out of curiosity, do we have a banner where we can add such things? http://gerrit.cloudera.org:8080/#/c/11191/4/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/11191/4/be/src/common/global-flags.cc@203 PS4, Line 203: Disable catalog operations that " : "require access to file-system data blocks. Useful for debugging " : "metadata issues." > nit: Can be formatted better to fit in fewer lines. clarified http://gerrit.cloudera.org:8080/#/c/11191/4/fe/src/main/java/org/apache/impala/util/AvroSchemaUtils.java File fe/src/main/java/org/apache/impala/util/AvroSchemaUtils.java: http://gerrit.cloudera.org:8080/#/c/11191/4/fe/src/main/java/org/apache/impala/util/AvroSchemaUtils.java@97 PS4, Line 97: " > Add the url too? Done http://gerrit.cloudera.org:8080/#/c/11191/4/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/11191/4/tests/common/custom_cluster_test_suite.py@202 PS4, Line 202: some lines > ..at least one line.. Done -- To view, visit http://gerrit.cloudera.org:8080/11191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15789fb489b285e2a6565025eb17c63cdc726354 Gerrit-Change-Number: 11191 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Sun, 12 Aug 2018 22:28:58 +0000 Gerrit-HasComments: Yes
