Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11179 )
Change subject: IMPALA-7419: Fix NullPointerException in SimplifyConditionalsRule ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11179/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11179/1//COMMIT_MSG@9 PS1, Line 9: coalesce > nit: coalesce Done http://gerrit.cloudera.org:8080/#/c/11179/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java File fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java: http://gerrit.cloudera.org:8080/#/c/11179/1/fe/src/main/java/org/apache/impala/rewrite/SimplifyConditionalsRule.java@79 PS1, Line 79: if (expr != simplified) { > are these the checks that expect expr/simplified to be analyzed? Done -- To view, visit http://gerrit.cloudera.org:8080/11179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d066b48c2824cc09ce21260ad06b3d50b14c54a Gerrit-Change-Number: 11179 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Thomas Marshall <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: yu feng <[email protected]> Gerrit-Comment-Date: Mon, 13 Aug 2018 18:24:00 +0000 Gerrit-HasComments: Yes
