Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11195 )
Change subject: IMPALA-5031: Remove some undefined behavior of NULL pointers ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11195/2/be/src/util/ubsan.h File be/src/util/ubsan.h: http://gerrit.cloudera.org:8080/#/c/11195/2/be/src/util/ubsan.h@21 PS2, Line 21: mimicking parts of the standard prone I'm not sure what that's trying to say. How is this mimicking? Isn't it guarding against? http://gerrit.cloudera.org:8080/#/c/11195/2/be/src/util/ubsan.h@35 PS2, Line 35: static void* MemCpy(void* dest, const void* src, size_t n) { is the point of these wrappers to allow nullptr when that's normally undefined? probably clarifying the top level comment would explain that. -- To view, visit http://gerrit.cloudera.org:8080/11195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c8a6624918389396789a83b32dbf068b9327f76 Gerrit-Change-Number: 11195 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 13 Aug 2018 20:36:03 +0000 Gerrit-HasComments: Yes
