Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11182 )
Change subject: IMPALA-7436: initial fetch-from-catalogd implementation ...................................................................... Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/#/c/11182/4/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/11182/4/be/src/catalog/catalog-server.cc@130 PS4, Line 130: // wait times, etc. > Also a TODO about limiting the number of such concurrent RPCs. Done http://gerrit.cloudera.org:8080/#/c/11182/1/be/src/exec/catalog-op-executor.cc File be/src/exec/catalog-op-executor.cc: http://gerrit.cloudera.org:8080/#/c/11182/1/be/src/exec/catalog-op-executor.cc@289 PS1, Line 289: const TNetworkAddress& address = > I think you could do something like DCHECK(use_local_catalog || TestInfo:: Done http://gerrit.cloudera.org:8080/#/c/11182/4/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/11182/4/be/src/service/fe-support.cc@543 PS4, Line 543: > nit: spacing. Done http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1827 PS4, Line 1827: > nit: Add method docs for these. Done http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1868 PS4, Line 1868: > nit: remove \n Done http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/Db.java File fe/src/main/java/org/apache/impala/catalog/Db.java: http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/Db.java@443 PS4, Line 443: public TGetPartialCatalogObjectResponse getPartialInfo( > nit: method doc. Done http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@263 PS4, Line 263: fds.add(fd.cloneWithNewHostIndex(resp.table_info.network_addresses, hostIndex)); > May be add a comment about the lifecycle of hostIndex and fd remapping. I h Done. This is also cleaned up a bit in the caching patch that follows this one. http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@300 PS4, Line 300: > I think it is nice to have some comments bout PartitionRefImp differences b Done http://gerrit.cloudera.org:8080/#/c/11182/4/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@344 PS4, Line 344: > nit: remove Done -- To view, visit http://gerrit.cloudera.org:8080/11182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49207fc592b1cc552fbcc7199568b6833f86901 Gerrit-Change-Number: 11182 Gerrit-PatchSet: 4 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 15 Aug 2018 06:52:03 +0000 Gerrit-HasComments: Yes
