Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11039 )
Change subject: IMPALA-7342: Add initial support for user-level permissions ...................................................................... Patch Set 24: (6 comments) http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java File fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java: http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/analysis/GrantRevokePrivStmt.java@93 PS21, Line 93: > these are roles now. if they will be extended to include user, pls add a to Done http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java File fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java: http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java@208 PS21, Line 208: return roleCache_.get(roleName); > can simplify to just: Done http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java@234 PS21, Line 234: > can't this just be: Done http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/catalog/AuthorizationPolicy.java@299 PS21, Line 299: s > nit: extra ws Done http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2973 PS21, Line 2973: Role role > Role Done http://gerrit.cloudera.org:8080/#/c/11039/21/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3015 PS21, Line 3015: Role role > Role Done -- To view, visit http://gerrit.cloudera.org:8080/11039 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I07e0d46d2e50d35bd64ee573b5aa4b779eb9e62f Gerrit-Change-Number: 11039 Gerrit-PatchSet: 24 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 15 Aug 2018 17:25:01 +0000 Gerrit-HasComments: Yes
