Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 )
Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11232/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/11232/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@636 PS1, Line 636: encodedFileDescriptors_.isEmpty() > getNumFileDescriptors() checks if encodedFileDescriptors_ == null, while th indeed that's bizarre... let me see if I can understand what's going on here. http://gerrit.cloudera.org:8080/#/c/11232/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@780 PS1, Line 780: getSize > If this is called often then it would be better to store the sum of sizes i I don't think this is called too often. Probably better to save the 8 bytes of RAM per partition vs try to optimize this unless we see it show up on some profile. -- To view, visit http://gerrit.cloudera.org:8080/11232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I986dd5c05ac8904898d01a6ef3487bd7225e0500 Gerrit-Change-Number: 11232 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 15 Aug 2018 18:59:27 +0000 Gerrit-HasComments: Yes
