Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11245 )
Change subject: IMPALA-7345: Add the OWNER privilege ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11245/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11245/1//COMMIT_MSG@10 PS1, Line 10: nit: extra whitespace http://gerrit.cloudera.org:8080/#/c/11245/1//COMMIT_MSG@10 PS1, Line 10: role for a role/user? http://gerrit.cloudera.org:8080/#/c/11245/1//COMMIT_MSG@11 PS1, Line 11: nit: extra whitespace http://gerrit.cloudera.org:8080/#/c/11245/1/fe/src/main/java/org/apache/impala/authorization/Privilege.java File fe/src/main/java/org/apache/impala/authorization/Privilege.java: http://gerrit.cloudera.org:8080/#/c/11245/1/fe/src/main/java/org/apache/impala/authorization/Privilege.java@68 PS1, Line 68: OWNER("owner", You should use the code from ALL, i.e. OWNER("owner", ALL.getCode()) -- To view, visit http://gerrit.cloudera.org:8080/11245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If63c2faa6daea6deb6d771503fe50943ae070705 Gerrit-Change-Number: 11245 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 04:39:51 +0000 Gerrit-HasComments: Yes
