Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11234 )
Change subject: IMPALA-7444: Improve logging of opening/closing/expiring sessions. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc@1962 PS2, Line 1962: expired_cnt++; > ++expired_cnt; Done http://gerrit.cloudera.org:8080/#/c/11234/2/be/src/service/impala-server.cc@1975 PS2, Line 1975: LOG_IF(INFO, expired_cnt > 0) << "Expired sessions. Count: " << expired_cnt : << ". Time: " << UnixMillis() - now << " milliseconds."; > What's the purpose of this line ? Won't we be able to tell that from the "E The idea is to gauge how long session_state_map_lock_ is held in the process of expiring sessions. Probably less of an issue today after stack symbolization is removed. -- To view, visit http://gerrit.cloudera.org:8080/11234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf2d3ce707cc36c21da8a2459c2f68cf0b56a4a Gerrit-Change-Number: 11234 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Thu, 16 Aug 2018 23:00:37 +0000 Gerrit-HasComments: Yes
