Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11229 )
Change subject: IMPALA-7439. CREATE DATABASE creates a catalog entry with missing location ...................................................................... IMPALA-7439. CREATE DATABASE creates a catalog entry with missing location Previously, when creating a new database, the CatalogOpExecutor would create an HMS Database object, issue the HMS createDatabase call, and then create a Catalog entry from that same Database object. The resulting Catalog entry would be missing certain fields that are auto-created by the HMS itself, most importantly the location field. The code for CTAS seems to have contained a workaround for this issue ever since catalogd was first introduced: rather than using the location stored in the Db object, it would re-fetch the Database from HMS. Now that this is fixed, that workaround could be removed and some code simplified. A new test verifies that a newly-created database has the appropriate location, and existing CTAS tests verify that functionality didn't regress. Change-Id: I13df31cee1e5768b073e0e35c4c16ebf1892be23 Reviewed-on: http://gerrit.cloudera.org:8080/11229 Reviewed-by: Vuk Ercegovac <vercego...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/analysis/CreateTableAsSelectStmt.java M fe/src/main/java/org/apache/impala/catalog/FeCatalog.java M fe/src/main/java/org/apache/impala/catalog/ImpaladCatalog.java M fe/src/main/java/org/apache/impala/catalog/local/LocalCatalog.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M testdata/workloads/functional-query/queries/QueryTest/create-database.test 6 files changed, 36 insertions(+), 50 deletions(-) Approvals: Vuk Ercegovac: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11229 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I13df31cee1e5768b073e0e35c4c16ebf1892be23 Gerrit-Change-Number: 11229 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
