Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11230 )
Change subject: IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable ...................................................................... IMPALA-7140 fix: fix NDV calculation for partition columns in LocalFsTable For partition columns, we were previously calculating the NDV by adding the count of partitions plus the count of null-partitions. However, all of the null partitions have the same value (NULL) so they only contribute one distinct value, regardless of how many there might be. This fixes an existing test case in test_compute_stats so doesn't include new tests. Change-Id: I0a86750d52dcd744ace030a3c1ec70510d054acf Reviewed-on: http://gerrit.cloudera.org:8080/11230 Reviewed-by: Vuk Ercegovac <[email protected]> Reviewed-by: Bharath Vissapragada <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Vuk Ercegovac: Looks good to me, approved Bharath Vissapragada: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11230 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0a86750d52dcd744ace030a3c1ec70510d054acf Gerrit-Change-Number: 11230 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]>
