Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11250 )
Change subject: IMPALA-7343: Update SentryProxy to use Sentry bulk API ...................................................................... Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/11250/6/fe/src/main/java/org/apache/impala/util/SentryProxy.java File fe/src/main/java/org/apache/impala/util/SentryProxy.java: http://gerrit.cloudera.org:8080/#/c/11250/6/fe/src/main/java/org/apache/impala/util/SentryProxy.java@149 PS6, Line 149: Refreshes pls be more specific with what you mean by "refresh". does it mean the local state will be updated to reflect adds, removals, and replacements that have been made to Sentry since the last check? http://gerrit.cloudera.org:8080/#/c/11250/6/fe/src/main/java/org/apache/impala/util/SentryProxy.java@223 PS6, Line 223: Refreshes similar clarification here. -- To view, visit http://gerrit.cloudera.org:8080/11250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ab215f2a5c5111bf1d25eec7fac90506d2f6304 Gerrit-Change-Number: 11250 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Adam Holley <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 17 Aug 2018 17:50:10 +0000 Gerrit-HasComments: Yes
