Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11236 )
Change subject: IMPALA-7453. Intern HdfsStorageDescriptors ...................................................................... Patch Set 2: (1 comment) Added a new test assertion http://gerrit.cloudera.org:8080/#/c/11236/2/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java File fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java: http://gerrit.cloudera.org:8080/#/c/11236/2/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@243 PS2, Line 243: public static HdfsStorageDescriptor fromThriftPartition(THdfsPartition thriftPartition, : String tableName) { : return INTERNER.intern(new HdfsStorageDescriptor(tableName, : HdfsFileFormat.fromThrift(thriftPartition.getFileFormat()), : thriftPartition.lineDelim, : thriftPartition.fieldDelim, : thriftPartition.collectionDelim, : thriftPartition.mapKeyDelim, : thriftPartition.escapeChar, : (byte) '"', // TODO: We should probably add quoteChar to THdfsPartition. : thriftPartition.blockSize)); : } : : public HdfsStorageDescriptor cloneWithChangedFileFormat(HdfsFileFormat newFormat) { : return INTERNER.intern(new HdfsStorageDescriptor("<unknown>", : newFormat, : lineDelim_, : fieldDelim_, : collectionDelim_, : mapKeyDelim_, : escapeChar_, : quoteChar_, : blockSize_)); : } > nit: format to fewer lines? Done -- To view, visit http://gerrit.cloudera.org:8080/11236 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ef93148d629b060fa9f67c631e9c3d904a0ccf9 Gerrit-Change-Number: 11236 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 17 Aug 2018 23:17:55 +0000 Gerrit-HasComments: Yes
