Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11208 )
Change subject: IMPALA-7437. LRU caching of partitions in impalad ...................................................................... Patch Set 5: (7 comments) initial comments. will look at tests next. http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@235 PS5, Line 235: List<ColumnStatisticsObj> ret = Lists.newArrayListWithCapacity(colNames.size()); what's the story for keeping track of how many rpc's are made and how long they take? I can see some instrumentation in 'sendRequest' being useful or were you thinking of using something that tracks rpc's more generally? I see cache stats is exposed above. how is that surfaced to higher? http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@268 PS5, Line 268: ret.size() should this be colNames.size()? perhaps we should also include the actual number of columns that we get at the end (per comment above where some might be missing). http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@289 PS5, Line 289: ret with req, resp, and ret all looking fairly similar, perhaps call this one "partitions" or "partitionRefs"? http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@423 PS5, Line 423: : nit: inconsistent spacing. I'm just going with file consistency-- I've completely forgotten which is the desired option here (":" or " : "). http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@567 PS5, Line 567: return String.format("%s.%s@%d", dbName_, tableName_, catalogVersion_); nit: add a "TableMetaRef: " to make it easier to know that we're looking at one of those. http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@596 PS5, Line 596: } nit: add a newline http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@376 PS5, Line 376: shoudl nit: should -- To view, visit http://gerrit.cloudera.org:8080/11208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a57521ad851da605604a1e7c48d3d6627da5df5 Gerrit-Change-Number: 11208 Gerrit-PatchSet: 5 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 20 Aug 2018 19:08:01 +0000 Gerrit-HasComments: Yes
