Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 )
Change subject: IMPALA-7433: reduce logging on executors ...................................................................... Patch Set 3: (2 comments) I'm open to reinstating some logs if there's a clear scenario where we need them, but I think we need to remove some of this "just in case" logging to reduce the signal-to-noise ratio. If there are specific error conditions we're concerned about maybe we can add targeted logging that will only be triggered if we're in an interesting case. http://gerrit.cloudera.org:8080/#/c/11202/3/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: http://gerrit.cloudera.org:8080/#/c/11202/3/be/src/runtime/query-exec-mgr.cc@155 PS3, Line 155: VLOG(2) > This may be useful for debugging issue such as IMPALA-7194. Not sure if the We separately log when each fragment instance completes, so this additional log doesn't provide that much information beyond this (aside from the refcnt and the fact that it made it slightly further along in the teardown path). I0813 12:10:50.417552 31256 query-state.cc:485] Instance completed. instance_id=fd4ae28bc993236e:27343be100000006 #in-flight=0 status=OK http://gerrit.cloudera.org:8080/#/c/11202/3/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/11202/3/be/src/runtime/query-state.cc@356 PS3, Line 356: VLOG(2) > This one may be useful to keep to indicate whether we manage to get to the We do already have log messages before and after this. I might be missing something but I don't see many things that can go wrong in that window. There are a couple of error paths for thread creation and QueryState::Init() where the status gets propagated back to the caller. I'll add logging of those errors actually. I0813 12:10:50.249850 31250 impala-internal-service.cc:49] ExecQueryFInstances(): query_id=fd4ae28bc993236e:27343be100000000 coord=tarmstrong-box:22000 #instances=2 I0813 12:10:50.250722 31256 query-state.cc:477] Executing instance. instance_id=fd4ae28bc993236e:27343be100000006 fragment_idx=1 per_fragment_instance_idx=2 coord_state_idx=1 #in-flight=1 -- To view, visit http://gerrit.cloudera.org:8080/11202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c1db44acc6def2b05a4fd032c63716e08cdf5ff Gerrit-Change-Number: 11202 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 20 Aug 2018 21:00:47 +0000 Gerrit-HasComments: Yes
