Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11182 )
Change subject: IMPALA-7436: initial fetch-from-catalogd implementation ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@314 PS8, Line 314: @Immutable Had to add this annotation to make errorprone happy after rebasing on d29300281b5d07c1ed98032536c008b076a7baa5 http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/main/java/org/apache/impala/catalog/local/DirectMetaProvider.java@311 PS8, Line 311: @Immutable this one too http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/main/java/org/apache/impala/catalog/local/MetaProvider.java@106 PS8, Line 106: @Immutable this one too http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java File fe/src/main/java/org/apache/impala/common/RuntimeEnv.java: http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/main/java/org/apache/impala/common/RuntimeEnv.java@46 PS8, Line 46: isTestEnv_ = false; Needed to add this in order to fix test runs. Without this, in 'mvn test', tests that run earlier would pollute tests that ran later. Specifically, the LocalCatalogTests ended up seeing some different behavior depending on whether this was set or not. http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@100 PS8, Line 100: RuntimeEnv.INSTANCE.reset(); fixed this cleanup to reset fully http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/test/java/org/apache/impala/planner/PlannerTest.java File fe/src/test/java/org/apache/impala/planner/PlannerTest.java: http://gerrit.cloudera.org:8080/#/c/11182/8/fe/src/test/java/org/apache/impala/planner/PlannerTest.java@532 PS8, Line 532: Assert.assertTrue(RuntimeEnv.INSTANCE.isTestEnv()); oops, didn't mean to add this. Will remove. -- To view, visit http://gerrit.cloudera.org:8080/11182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49207fc592b1cc552fbcc7199568b6833f86901 Gerrit-Change-Number: 11182 Gerrit-PatchSet: 8 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Mon, 20 Aug 2018 22:02:50 +0000 Gerrit-HasComments: Yes
