Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11253 )
Change subject: IMPALA-7457. statestore: allow filtering by key prefix ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11253/2/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/11253/2/be/src/statestore/statestore-subscriber.cc@46 PS2, Line 46: using std::string; > hrm, isn't that against the style guide, though? you aren't supposed to hav Right, common/names.h is the one exception since it's just a shortcut to pull in a bunch of common using declarations into a .cc file. Including common/names.h in another header would be a big no-no. -- To view, visit http://gerrit.cloudera.org:8080/11253 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ddcf3bfaf16bc3cd1ba01100e948ff142a67620 Gerrit-Change-Number: 11253 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Tue, 21 Aug 2018 03:11:36 +0000 Gerrit-HasComments: Yes
