Hello Lars Volker, Philip Zeyliger, David Knupp, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11264
to look at the new patch set (#4).
Change subject: WIP: IMPALA-7460 part 1: require user to install Paramiko and
Fabric
......................................................................
WIP: IMPALA-7460 part 1: require user to install Paramiko and Fabric
- Remove Fabric and Paramiko as requirements. They aren't needed by
anything in buildall.sh.
- Add a means to install into the impala-python virtual environment by hand.
impala-pip is fine for this.
- Add another requirements file for extended testing. The dependency
situation is messy and untangling that out of impala-python and into
lib/python should be out of the scope of IMPALA-7460.
- Update core tests, which cover real regressions that have happened in
the past, to run against locations that don't require a Paramiko
import. This moves some logic out of concurrent_select.py into a
thinner module.
- Insulate ssh_util from globally-scoped import so that it only imports
when needed.
Testing:
- This works in my development environment.
- This works in my downstream stress and query gen environments.
- This works when doing a full data load.
- Impala still builds on a variety of OSs.
Todo:
- A subsequent review will update the versions.
Change-Id: Ibf9010a0387b52c95b7bda5d1d4606eba1008b65
---
A bin/impala-pip
M infra/python/deps/compiled-requirements.txt
A infra/python/deps/extended-test-requirements.txt
M tests/comparison/cluster.py
M tests/comparison/leopard/impala_docker_env.py
M tests/infra/test_stress_infra.py
M tests/stress/concurrent_select.py
M tests/util/cluster_controller.py
M tests/util/parse_util.py
M tests/util/ssh_util.py
M tests/util/test_file_parser.py
11 files changed, 157 insertions(+), 82 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/11264/4
--
To view, visit http://gerrit.cloudera.org:8080/11264
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf9010a0387b52c95b7bda5d1d4606eba1008b65
Gerrit-Change-Number: 11264
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Brown <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
