Michael Brown has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11257 )

Change subject: IMPALA-7399: Emit a junit xml report when trapping errors
......................................................................


Patch Set 9: Code-Review+1

(2 comments)

Phil had good comments. I had looked at an earlier patch set and didn't have 
much more to say. This looks good to me now though.

http://gerrit.cloudera.org:8080/#/c/11257/9/lib/python/impala_py_lib/jenkins/generate_junitxml.py
File lib/python/impala_py_lib/jenkins/generate_junitxml.py:

http://gerrit.cloudera.org:8080/#/c/11257/9/lib/python/impala_py_lib/jenkins/generate_junitxml.py@164
PS9, Line 164: {}
Not python2.6-compatible. Use {0}


http://gerrit.cloudera.org:8080/#/c/11257/9/testdata/bin/check-schema-diff.sh
File testdata/bin/check-schema-diff.sh:

http://gerrit.cloudera.org:8080/#/c/11257/9/testdata/bin/check-schema-diff.sh@30
PS9, Line 30: the same trap function used by other shell scripts
just say "we don't call setup_report_build_error".



--
To view, visit http://gerrit.cloudera.org:8080/11257
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd62045bb43357abc2b89a78afff499149d3c3fc
Gerrit-Change-Number: 11257
Gerrit-PatchSet: 9
Gerrit-Owner: David Knupp <[email protected]>
Gerrit-Reviewer: David Knupp <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Brown <[email protected]>
Gerrit-Reviewer: Nithya Janarthanan <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Comment-Date: Wed, 22 Aug 2018 22:00:43 +0000
Gerrit-HasComments: Yes

Reply via email to