Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11231 )
Change subject: IMPALA-7447. Evict LocalCatalog cache entries based on size ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11231/6/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/11231/6/be/src/runtime/exec-env.cc@86 PS6, Line 86: DEFINE_int32_hidden(local_catalog_cache_mb, -1, : "If --use_local_catalog is enabled, configures the size of the catalog " : "cache within each impalad. If this is set to -1, the cache is auto-" : "configured to 60% of the configured Java heap size. Note that the Java " : "heap size is distinct from and typically smaller than the overall " : "Impala memory limit.") IMO, from a end user POV, it is less confusing if this directly exposes the % configuration. Something like local_catalog_heap_max_percent... Given we already have a max_heap (-Xmx), this would confuse users as to why they need to configure two separate values. Anyway we probably don't expect the customers to change this often, so feel free to ignore if that is the case. -- To view, visit http://gerrit.cloudera.org:8080/11231 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia96af49b35c17e505b7b6785e78d140939085d91 Gerrit-Change-Number: 11231 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Wed, 22 Aug 2018 23:27:59 +0000 Gerrit-HasComments: Yes
