Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11296 )
Change subject: IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() ...................................................................... IMPALA-7418: Return first non-ok status from HdfsScanNode::GetNext() Previously, HdfsScanNode::GetNext passed the status returned by IssueInitialScanRanges() without inspecting the HdfsScanNodeBase::status_. This resulted in the error status being lost in case a scanner thread hit an error and cancelled the scan. This change ensures that GetNext() returns the first non-ok status set in HdfsScanNode. Testing: Added sleeps to the IssueInitialRanges() to cause deterministic failures of test_udf_errors and then applied this patch to it. It passes all the tests despite the sleeps. Change-Id: I4569cc7b0843a29c617a094e590c31f7c648ff45 Reviewed-on: http://gerrit.cloudera.org:8080/11296 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/hdfs-scan-node-base.h M be/src/exec/hdfs-scan-node.cc 2 files changed, 14 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4569cc7b0843a29c617a094e590c31f7c648ff45 Gerrit-Change-Number: 11296 Gerrit-PatchSet: 6 Gerrit-Owner: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pooja Nilangekar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
