Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 )
Change subject: IMPALA-6758: Add metric for current catalog version to catalog ...................................................................... Patch Set 3: (1 comment) I'm curious: what's the motivation for exposing this as a metric? Why would the operator want to monitor it? http://gerrit.cloudera.org:8080/#/c/11293/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/11293/3/be/src/catalog/catalog-server.cc@185 PS3, Line 185: current_catalog_version_metric_ = catalog_metrics->AddGauge : (CATALOG_CURRENT_TOPIC_VERSION can you clarify which version this is? Confusingly there are two versions floating around the catalog code -- there is the *topic* version (set by the statestore) and the catalog version (set by the catalogd). We often use the wrong term to refer to the thing we're dealing with, and it seems we are continuing to proliferate such inclarities here. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Vincent Tran <[email protected]> Gerrit-Comment-Date: Fri, 24 Aug 2018 22:32:34 +0000 Gerrit-HasComments: Yes
