Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11330 )
Change subject: IMPALA-7490: fix uninitialized variables in load-data.py ...................................................................... Patch Set 1: (3 comments) Thank you for taking this on. A few comments. http://gerrit.cloudera.org:8080/#/c/11330/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11330/1//COMMIT_MSG@11 PS1, Line 11: faield Nit: failed http://gerrit.cloudera.org:8080/#/c/11330/1/bin/load-data.py File bin/load-data.py: http://gerrit.cloudera.org:8080/#/c/11330/1/bin/load-data.py@204 PS1, Line 204: query_parsed = True Another option is to have a boolean "impala_client_connected" that starts False and gets set to true after the "impala_client.connect()". That would let you have a more specific error message like "Failed to connect to Impala". The remaining errors could be in parsing or execution. As you mentioned, query might not be set. To deal with that, you can define query up front to be None or we can keep track of the state like you are doing and have a different error. http://gerrit.cloudera.org:8080/#/c/11330/1/bin/load-data.py@295 PS1, Line 295: else: : LOG.error('Unknown execution type: %s' % execution_type) : return We already asserted that execution_type='impala' or 'hive' above, so this is not needed. -- To view, visit http://gerrit.cloudera.org:8080/11330 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0dd56a9b78a60b3a9f04d9f61e93b4b5d066b76 Gerrit-Change-Number: 11330 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 27 Aug 2018 17:24:14 +0000 Gerrit-HasComments: Yes
