Pooja Nilangekar has posted comments on this change. ( http://gerrit.cloudera.org:8080/11052 )
Change subject: IMPALA-6644: Add last heartbeat timestamp into Statestore metric ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/11052/11/be/src/statestore/statestore.h File be/src/statestore/statestore.h: http://gerrit.cloudera.org:8080/#/c/11052/11/be/src/statestore/statestore.h@393 PS11, Line 393: tatic_ > nit: maybe use a static_cast Done http://gerrit.cloudera.org:8080/#/c/11052/11/be/src/statestore/statestore.h@466 PS11, Line 466: /// older than the heartbeat frequency implies an unresponsive subscriber. > nit: AtomicInt64 last_heartbeat_ts_{0} Done http://gerrit.cloudera.org:8080/#/c/11052/11/be/src/statestore/statestore.cc File be/src/statestore/statestore.cc: http://gerrit.cloudera.org:8080/#/c/11052/11/be/src/statestore/statestore.cc@1001 PS11, Line 1001: for (const a > nit: you can use SleepForMs instead and get rid of extra includes Done -- To view, visit http://gerrit.cloudera.org:8080/11052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754adccc4569e8219d5d01500cccdfc8782953f7 Gerrit-Change-Number: 11052 Gerrit-PatchSet: 12 Gerrit-Owner: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 29 Aug 2018 00:32:58 +0000 Gerrit-HasComments: Yes
