Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11297 )
Change subject: IMPALA-7477: Batch-oriented query set construction ...................................................................... Patch Set 7: Code-Review+1 (1 comment) Found a small issue. After fixing it I can +2 it. Unless you want others to look at it too. http://gerrit.cloudera.org:8080/#/c/11297/7/be/src/service/hs2-util.cc File be/src/service/hs2-util.cc: http://gerrit.cloudera.org:8080/#/c/11297/7/be/src/service/hs2-util.cc@137 PS7, Line 137: values I think it should be 'nulls'. -- To view, visit http://gerrit.cloudera.org:8080/11297 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc87a84c34935d0d5841c7f5528eb802527fa809 Gerrit-Change-Number: 11297 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Aug 2018 14:19:52 +0000 Gerrit-HasComments: Yes
