Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/11331 )
Change subject: Add missing authorization in KRPC ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Testing side LGTM. http://gerrit.cloudera.org:8080/#/c/11331/5/be/src/rpc/rpc-mgr-kerberized-test.cc File be/src/rpc/rpc-mgr-kerberized-test.cc: http://gerrit.cloudera.org:8080/#/c/11331/5/be/src/rpc/rpc-mgr-kerberized-test.cc@114 PS5, Line 114: rpc_status = : FromKuduStatus(scan_proxy->ScanMem(scan_request, &scan_response, &controller)); : EXPECT_TRUE(rpc_status.ok()); So, this is passing only because the Authorize() function for ScanMemServiceImpl always returns true right? I had to read across files to figure that out. I think adding a comment like the following should make the test easier to understand: "ScanMemServiceImpl authorizes everyone connecting to the service, so we expect it to pass even though we have a different principal name". And the opposite for PingServiceImpl. -- To view, visit http://gerrit.cloudera.org:8080/11331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f82dee5e721f2ed23e75fd91abbc6ab7addd4c5 Gerrit-Change-Number: 11331 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 29 Aug 2018 16:55:11 +0000 Gerrit-HasComments: Yes
