Hello Bharath Vissapragada, Vuk Ercegovac,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11357
to review the following change.
Change subject: IMPALA-7137 fixup: only recreate AuthorizationChecker on full
delta updates
......................................................................
IMPALA-7137 fixup: only recreate AuthorizationChecker on full delta updates
This is a follow-up to commit a90b42911f1753b14e4f9f581bad837e33dcf9bf
which had an unintended side-effect even when LocalCatalog is not
enabled: previously we would only re-instantiate AuthorizationChecker on
"full" catalog updates; after that patch, we would re-instantiate it on
every catalog update.
While it appears that this is relatively cheap and didn't cause any
obvious behavioral changes, it wasn't intended, and one of the goals of
the --use_local_catalog flag being optional is that the existing code
paths shouldn't be affected. So, this puts it back the way it was.
Thanks to Adam Holley for noticing this and alerting me to my mistake.
Change-Id: I47f5945fd64c0adf3fe7fd82076f64672358f962
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/57/11357/1
--
To view, visit http://gerrit.cloudera.org:8080/11357
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47f5945fd64c0adf3fe7fd82076f64672358f962
Gerrit-Change-Number: 11357
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Vuk Ercegovac <[email protected]>