Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11352 )
Change subject: IMPALA-7508: Add Impala Python GDB module ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11352/2/lib/python/impala_py_lib/gdb/impala-gdb.py File lib/python/impala_py_lib/gdb/impala-gdb.py: http://gerrit.cloudera.org:8080/#/c/11352/2/lib/python/impala_py_lib/gdb/impala-gdb.py@30 PS2, Line 30: def get_fragment_instances(): > flake8: E302 expected 2 blank lines, found 1 Fixed. http://gerrit.cloudera.org:8080/#/c/11352/2/lib/python/impala_py_lib/gdb/impala-gdb.py@44 PS2, Line 44: s > flake8: F841 local variable 'symbol' is assigned to but never used Fixed -- To view, visit http://gerrit.cloudera.org:8080/11352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24e7026f2265954ed592d6f62110cf8cb2c2202a Gerrit-Change-Number: 11352 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 30 Aug 2018 22:26:32 +0000 Gerrit-HasComments: Yes
