Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11341 )
Change subject: IMPALA-7424: Reduce in-memory footprint of incremental stats ...................................................................... Patch Set 7: (7 comments) http://gerrit.cloudera.org:8080/#/c/11341/6/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/11341/6/common/thrift/CatalogObjects.thrift@303 PS6, Line 303: optional > shouldn't this be optional since we don't need to send this to backends as Done http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@322 PS6, Line 322: thriftHdfsPart.setId(part.getId()); > per comment elsewhere, I dont think you need this in the non-FULL (descript Yep missed this. http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@32 PS6, Line 32: import org.apache.hadoop.fs.BlockLocation; > nit: this should sort down with the other guava stuff Done http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@668 PS6, Line 668: // Delete the incremental stats entries. > I think you could simplify this code a bit and write: neat, done! http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@693 PS6, Line 693: > nit: typo Done http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1712 PS6, Line 1712: > it's somewhat weird that this one is required. I would include it optionall Done http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/util/CompressionUtil.java File fe/src/main/java/org/apache/impala/util/CompressionUtil.java: http://gerrit.cloudera.org:8080/#/c/11341/6/fe/src/main/java/org/apache/impala/util/CompressionUtil.java@43 PS6, Line 43: > curious if you compared the compression ratio and performance of BEST_COMPR I noticed that BEST_COMPRESSION had a slightly better (not too much) compression ratio. I don't have the numbers now. Adding a TODO though. -- To view, visit http://gerrit.cloudera.org:8080/11341 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39f02ebfa0c6e9b0baedd0d76058a1b34efb5a02 Gerrit-Change-Number: 11341 Gerrit-PatchSet: 7 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 31 Aug 2018 05:31:05 +0000 Gerrit-HasComments: Yes
